[DF] Allow snapshotting from TTree to RNTuple #19364
Open
+99
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Templated snapshotting has been removed, so the "*Templated" and "*JITted" tests have become identical.
enirolf
requested review from
jblomer,
hahnjo,
pcanal,
silverweed and
vepadulano
enirolf
force-pushed
the
rdf-snap-ttree-to-rntuple
branch
from
46413f9 to
26dc6f0
Compare
Test Results 21 files 21 suites 3d 10h 44m 47s ⏱️ For more details on these failures, see this check. Results for commit 70e54ce. ♻️ This comment has been updated with latest results. |
hahnjo
reviewed
Jul 15, 2025
| { | ||
| ASSERT_EQ(v1.size(), v2.size()) << "Vectors 'v1' and 'v2' are of unequal length"; | ||
| for (std::size_t i = 0ull; i < v1.size(); ++i) { | ||
| EXPECT_EQ(v1[i], v2[i]) << "Vectors 'v1' and 'v2' differ at index " << i; |
There was a problem hiding this comment.
Just a heads up that we may need EXPECT_FLOAT_EQ here, depending on what T is. I think for the moment it's fine because { 1.f, 2.f, 3.f } are exactly representable.
enirolf
force-pushed
the
rdf-snap-ttree-to-rntuple
branch
from
26dc6f0 to
70e54ce
Compare
jblomer
reviewed
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshotting from TTree to RNTuple was initially disabled, because it was assumed that this would require adopting (parts of) the machinery of the RNTupleImporter to make it work. However, this is all already taken care of by the TTree's datasource.
One caveat is the support of leaflist branches. It is not possible to snapshot these fully, and users always need to explicitly pass their leaf names to
Snapshot. This, however, is something fundamentally unsupported by the RDataFrame. The reason is that for snapshotting to TTree, it is impossible/overly complex to correctly set the branch addresses in the output TTree for these branches at runtime, without JITting. For RNTuple, however, this is likely more doable by using untyped record fields (similar to how it is done in the importer). This requires some more investigation, however, and if indeed possible will be addressed in a follow-up PR.