Skip to content

[Proof] Remove PROOF #19356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dpiparo
Copy link
Member

@dpiparo dpiparo commented Jul 14, 2025

And all traces of it in the code base.

@dpiparo dpiparo self-assigned this Jul 14, 2025
Copy link

github-actions bot commented Jul 14, 2025

Test Results

    21 files      21 suites   3d 10h 41m 51s ⏱️
 3 211 tests  3 207 ✅ 0 💤 4 ❌
65 699 runs  65 695 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 68035c4.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo force-pushed the remove_proof branch 2 times, most recently from 4ee1791 to c686c70 Compare July 15, 2025 09:20
@dpiparo dpiparo marked this pull request as ready for review July 15, 2025 12:18
@dpiparo dpiparo removed request for couet, lmoneta and bellenot July 15, 2025 12:19
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the RooFit part!

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me for the few changes to bindings. In general I'm glad to see such a large reduction of the code base.

@dpiparo
Copy link
Member Author

dpiparo commented Jul 15, 2025

This PR just incarnates the mechanics of a decision the project took about a year ago, clearly communicated in the Release Notes. PROOF allowed interactive distributed analysis a decade or more before popular frameworks and served us well. By now its functionality is entirely provided by RDataFrame and its distributed version and we can afford to remove it from the code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants