-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Proof] Remove PROOF #19356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Proof] Remove PROOF #19356
Conversation
Test Results 21 files 21 suites 3d 10h 41m 51s ⏱️ For more details on these failures, see this check. Results for commit 68035c4. ♻️ This comment has been updated with latest results. |
4ee1791
to
c686c70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the RooFit part!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me for the few changes to bindings
. In general I'm glad to see such a large reduction of the code base.
This PR just incarnates the mechanics of a decision the project took about a year ago, clearly communicated in the Release Notes. PROOF allowed interactive distributed analysis a decade or more before popular frameworks and served us well. By now its functionality is entirely provided by RDataFrame and its distributed version and we can afford to remove it from the code base. |
And all traces of it in the code base.