Skip to content

[build] Simplify CMake in ATLAS DataVector test directory #19344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vepadulano
Copy link
Member

Using the NO_CXXMODULE option of ROOTTEST_GENERATE_DICTIONARY produces dictionary artifacts that correctly reproduce the ATLAS environment (i.e. there are no C++ module neither modulemap produced in the test build directory).

Using the `NO_CXXMODULE` option of `ROOTTEST_GENERATE_DICTIONARY` produces
dictionary artifacts that correctly reproduce the ATLAS environment (i.e. there
are no C++ module neither modulemap produced in the test build directory).
@vepadulano vepadulano requested a review from pcanal July 11, 2025 11:59
@vepadulano vepadulano self-assigned this Jul 11, 2025
@vepadulano vepadulano requested a review from bellenot as a code owner July 11, 2025 11:59
@vepadulano vepadulano added the clean build Ask CI to do non-incremental build on PR label Jul 11, 2025
Copy link

github-actions bot commented Jul 11, 2025

Test Results

    20 files      20 suites   3d 8h 21m 18s ⏱️
 3 195 tests  3 194 ✅ 0 💤 1 ❌
62 303 runs  62 302 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit a975161.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo self-requested a review July 14, 2025 05:56
Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these changes. I am approving the PR, with the caveat that the debian failure perhaps deserves a closer look before merging.

@vepadulano
Copy link
Member Author

Indeed the failure https://github.com/root-project/root/actions/runs/16219472129/job/45796305238?pr=19344#step:11:12437 is worrying

   ============================= test session starts ==============================
  platform linux -- Python 3.9.21, pytest-8.4.1, pluggy-1.6.0
  rootdir: /github/home/ROOT-CI
  plugins: anyio-4.9.0
  collected 1 item
  
  ../../../../../src/roottest/root/ntuple/atlas-datavector/template_instantiation.py F [100%]
  
  =================================== FAILURES ===================================
  _________ TestTemplateInstantiation.test_instantiate_function_template _________
  
  self = <template_instantiation.TestTemplateInstantiation object at 0x7f005ea90d30>
  
      def test_instantiate_function_template(self):
          import ROOT
      
          ROOT.gInterpreter.Declare(r"template <typename T> void foo() {}")
      
          # The call raises an exception that the function cannot be found.
          # What is really happening is that a template instantiation is tried
          # with the "wrong" signature, as the class type passed by the user is
          # not what the compiler sees.
          field_type_name = "AtlasLikeDataVector<CustomStruct>"
          with pytest.raises(TypeError):
              ROOT.foo[field_type_name]()
      
          # The first attempt at instantiating the template has had the side
          # effect of loading the dictionary information for AtlasLikeDataVector,
          # including the alternative class type names
          alt_field_type_names = ROOT.TClassTable.GetClassAlternativeNames(field_type_name)
      
          fully_qualified_type_name = "AtlasLikeDataVector<CustomStruct, DataModel_detail::NoBase>"
      
  >       assert len(alt_field_type_names) == 1
  E       assert 0 == 1
  E        +  where 0 = len(vector<string>{})
  
  ../../../../../src/roottest/root/ntuple/atlas-datavector/template_instantiation.py:25: AssertionError
  =========================== short test summary info ============================
  FAILED ../../../../../src/roottest/root/ntuple/atlas-datavector/template_instantiation.py::TestTemplateInstantiation::test_instantiate_function_template - assert 0 == 1
   +  where 0 = len(vector<string>{})
  ============================== 1 failed in 1.71s ===============================
  CMake Error at /github/home/ROOT-CI/build/RootTestDriver.cmake:232 (message):
    error code: 1

It's unclear to me whether it happens because of the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean build Ask CI to do non-incremental build on PR in:Build System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants