[ntuple] improve type name renormalization #19323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
force-pushed
the
ntuple-type-normalization
branch
from
e3747e0 to
3153961
Compare
Test Results 21 files 21 suites 3d 11h 37m 56s ⏱️ For more details on these failures, see this check. Results for commit 26d39e5. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Jul 10, 2025
hahnjo
reviewed
Jul 11, 2025
|
Maybe related: https://its.cern.ch/jira/browse/ROOT-5862 |
jblomer
force-pushed
the
ntuple-type-normalization
branch
from
3153961 to
b4d5353
Compare
jblomer
force-pushed
the
ntuple-type-normalization
branch
3 times, most recently
from
c6e2dfa to
3c71f5e
Compare
Add clarifications on type name normalization wrt. - type name resolution of stdlib types - treatment of C style fixed-size arrays. Both points follow implicitly from the specification of the supported C++ types but it is useful to add them explicitly to the type name normalization rules. Since in the process also bugs were discovered related to fixed-size arrays, we give this specification a bump in the patch version number.
Add different code path for renormalizing a demangled typeid name. Such type names come from RField<T>::TypeName(). In this case, the compiler has done already most of the normalization work and we don't need to go through ROOT meta. There are some parts ROOT meta does that we need to repeat for this case, e.g. dropping optional template arguments of stdlib containers.
jblomer
force-pushed
the
ntuple-type-normalization
branch
from
29e2966 to
26d39e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add different code path for renormalizing a demangled typeid name. Such type names come from
RField<T>::TypeName(). In this case, the compiler has done already most of the normalization work and we don't need to go through ROOT meta. More importantly, the result does not depend on the state of ROOT Meta, e.g. the set of loaded libraries.There are some parts ROOT meta does that we need to repeat for this case, e.g. dropping optional template arguments of stdlib containers.
Secondly, this PR clarifies and fixes normalization of C style fixed-size arrays.
Together, this makes the new patch version 1.0.0.2 of the spec and the anchor.
This PR fixes #19116