-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ntuple] Fields tree as dot #19319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ntuple] Fields tree as dot #19319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks! I left a couple of comments.
Also, do you have maybe a screenshot of an example rendered output?
Test Results 21 files 21 suites 3d 16h 36m 52s ⏱️ For more details on these failures, see this check. Results for commit 5294d78. ♻️ This comment has been updated with latest results. |
eea7cd2
to
e94ea8b
Compare
b625a75
to
4010324
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple more things before we merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! Can I suggest to clean the commit history before merging? That would include squashing formatting/small fixes commits together in one (or a few) main commits and using our convention for the commit message e.g.
[ntuple] VERB_IMPERATIVE_FORM description_of_commit_objective
d8f4631
to
66eb4d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! I have some small nitpicks to address before merging, but after that it's good to go from my side :).
76f8da4
to
16f0efa
Compare
The requested changes should be implemented, I'll squash the commits now. |
5e7857f
to
4b1cc43
Compare
4b1cc43
to
5294d78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, LGTM!
This Pull request:
Changes or fixes:
This PR introduces the method
RNTupleInspector::GetFieldsTreeAsDot
which gives a string that represents the tree structure of RNTuple fields in .dot language (that can then be displayed in graphviz for example)Checklist: