Skip to content

[tree] TTree::SetAlias() properly interpret the constant v2 #18319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented Apr 8, 2025

This Pull request:

Changes or fixes:

This explores a variation of #17707 (comment) homogeneizing checks

Fixes https://its.cern.ch/jira/browse/ROOT-4012

Regression since bfbfe87

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury ferdymercury requested a review from pcanal as a code owner April 8, 2025 18:20
Fixes https://its.cern.ch/jira/browse/ROOT-4012

Regression since root-project@bfbfe87

[test] check that the alias value is properly substituted

as suggested by pcanal

[test] add second test
and fix some typos
@ferdymercury ferdymercury force-pushed the aliask2 branch 2 times, most recently from ba270bf to 4ec0ed2 Compare April 8, 2025 18:35
@ferdymercury ferdymercury force-pushed the aliask2 branch 2 times, most recently from 7c7aace to 08dc7e3 Compare April 8, 2025 18:40
Copy link

github-actions bot commented Apr 8, 2025

Test Results

    19 files      19 suites   5d 0h 53m 39s ⏱️
 2 720 tests  2 720 ✅ 0 💤 0 ❌
49 925 runs  49 925 ✅ 0 💤 0 ❌

Results for commit f1e4dd5.

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@pcanal pcanal merged commit 78d4c82 into root-project:master Apr 9, 2025
23 checks passed
@ferdymercury ferdymercury deleted the aliask2 branch April 9, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants