[webgui] testing /snap/bin/chromium #18311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files 17 suites 3d 22h 47m 58s ⏱️ Results for commit 716edfc. ♻️ This comment has been updated with latest results. |
Try to detect snap version before normal one. Partially resolves https://root-forum.cern.ch/t/63182/ Let use snap installation of chromium on the platform where precompiled ROOT version is used
/snap/bin/chromium has restriction to access general temporary directory. Therefore if TMPDIR is not set, try to use directly home directory. Also in some other installations chromium may have restriction to access HTML files from tmp dir. Code was exists already for batch case - now extend it as well.
Temporary file required to start browser. Then connection established - information is not longer necessary. Also increase security.
couet
approved these changes
Apr 10, 2025
|
Yes, I applied clang-format and didnot check result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves https://root-forum.cern.ch/t/63182/
Let use snap installation of chromium on the platform where pre-compiled ROOT version is used
Also add special handling of temporary directory.
snap version of chromium has limitation that files from
/tmpcannot be accessed. Therefore if TMPDIR is not set, try to use directly home directory.
Adjust batch code to use new functionality with temp directory
Delete temporary HTML file as soon as connection is established