Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntuple] Skip columns without pages in RNTupleInspector #17787

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[ntuple] Skip columns without pages in RNTupleInspector #17787

wants to merge 2 commits into from
+22 −5

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Feb 20, 2025

No description provided.

@hahnjo hahnjo self-assigned this Feb 20, 2025
@hahnjo hahnjo requested a review from jblomer as a code owner February 20, 2025 16:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Test Results

    18 files      18 suites   4d 8h 55m 20s ⏱️
 2 719 tests  2 719 ✅ 0 💤 0 ❌
47 253 runs  47 253 ✅ 0 💤 0 ❌

Results for commit 3237908.

♻️ This comment has been updated with latest results.

enirolf
enirolf requested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@enirolf enirolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this catch! LGTM, but the same check will have to be added before line 369 for completeness.

@hahnjo hahnjo force-pushed the inspector-no-pages branch from 258a412 to 3237908 Compare February 24, 2025 09:31
@hahnjo hahnjo requested a review from enirolf February 24, 2025 09:31
enirolf
enirolf approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@enirolf enirolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Perhaps squash the two commits before merging.

@hahnjo hahnjo changed the title [ntuple] Skip column types without pages in RNTupleInspector [ntuple] Skip columns without pages in RNTupleInspector Feb 24, 2025
@hahnjo
Copy link
Member Author

hahnjo commented Feb 24, 2025

Thanks! Perhaps squash the two commits before merging.

It's two individual fixes though, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverweed silverweed silverweed left review comments

@enirolf enirolf enirolf approved these changes

@pcanal pcanal Awaiting requested review from pcanal

@vepadulano vepadulano Awaiting requested review from vepadulano

@jblomer jblomer Awaiting requested review from jblomer jblomer is a code owner

Assignees

@hahnjo hahnjo

Labels
in:RNTuple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hahnjo @silverweed @enirolf