Skip to content

fix: overly-broad regular expressions #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cassidyjames merged 4 commits into from
Aug 26, 2026
+4 −3
Merged

fix: overly-broad regular expressions #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1b3b94
Strings UDF: correct overly-broad l33t regex
cassidyjames Aug 25, 2026
5d807e9
RichDescription: Correct alphanumeric regexp
cassidyjames Aug 26, 2026
5da466d
RichDescription: use word character for regex
cassidyjames Aug 26, 2026
cae51e9
String UDF: Add comment about l33t unicode matching
cassidyjames Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions osprey_ui/src/components/entities/RichDescription.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ interface RichDescriptionProps {
features: { [featureName: string]: string };
}

const INTERPOLATE_REG_EX = /{([A-z0-9_]+)}/;
const SPLIT_REG_EX = /(:?{[A-z0-9_]+})/;
const INTERPOLATE_REG_EX = /{(\w+)}/;
const SPLIT_REG_EX = /(:?{\w+})/;

const RichDescription = ({ description, features }: RichDescriptionProps) => {
const interpolatedDescription = description.split(SPLIT_REG_EX).map((part, i) => {
Expand Down
3 changes: 2 additions & 1 deletion osprey_worker/src/osprey/engine/stdlib/udfs/string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ class StringCleaningArguments(StringArguments):
)

# sub for l33t -> leet
_L33T_THREES_SUB_PATTERN: re.Pattern[str] = re.compile(r'([A-z]?)(3+)([A-z]?)', flags=re.IGNORECASE)
# with IGNORECASE this matches 3s surrounded by unicode letters like İ, ı, ſ, and K which is expected
_L33T_THREES_SUB_PATTERN: re.Pattern[str] = re.compile(r'([A-Za-z]?)(3+)([A-Za-z]?)', flags=re.IGNORECASE)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Comment thread
cassidyjames marked this conversation as resolved.

# sub for |7 -> 17
_L33T_PIPE_NUMBER_SUB_PATTERN: re.Pattern[str] = re.compile(r'\|(\d)')
Expand Down
Loading