Skip to content

Handle filters for removed table columns - #1033

Open
taobojlen wants to merge 2 commits into
fix/zero-numeric-range-boundsfrom
fix/stale-table-filter-columns
Open

Handle filters for removed table columns#1033
taobojlen wants to merge 2 commits into
fix/zero-numeric-range-boundsfrom
fix/stale-table-filter-columns

Conversation

@taobojlen

@taobojlen taobojlen commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Context & Requests for Reviewers

This PR fixes a kind of niche bug that CodeRabbit found. To repro it:

  • Click "Filter" on a table and start entering a value, but don't hit Save
  • Click "Columns" while the filter menu remains open
  • Uncheck the column you started writing a filter for
  • Click "Save" in the filter menu

Before, this would crash. No more.

I'm unsure if this is worth the added complexity. What do you think?

Tests

Manually tested.

(Optional) Rollout Plan

N/A

Checklist

Only check items that apply to this PR; leave the rest unchecked.

  • If you changed anything user-facing (i.e. user interface or APIs):
    Did you update the CHANGELOG.md and related docs?

  • If you changed server/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:
    Did you update the corresponding history tables and their triggers?

  • If you changed db/src/scripts/** and used CREATE TABLE, ADD COLUMN, or ALTER COLUMN:
    Are as many columns marked NOT NULL as possible? If some columns can sometimes be null depending on other columns, are there CHECK constraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?

  • If you added a new signal in server/services/signalsService/signals/**:
    Did you classify every error case as a permanent error (SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be a SignalPermanentError.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dfd71933-1903-4fbf-af55-b3e261d589ad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@taobojlen taobojlen mentioned this pull request Aug 18, 2026
4 tasks
@taobojlen
taobojlen force-pushed the fix/stale-table-filter-columns branch from e018903 to 6892d2b Compare August 18, 2026 10:00
@taobojlen
taobojlen force-pushed the fix/stale-table-filter-columns branch from 6892d2b to db651b6 Compare August 18, 2026 10:13
@taobojlen
taobojlen force-pushed the fix/stale-table-filter-columns branch from db651b6 to 1ebc995 Compare August 18, 2026 10:19
@taobojlen
taobojlen marked this pull request as ready for review August 18, 2026 11:38
@taobojlen
taobojlen force-pushed the fix/stale-table-filter-columns branch 2 times, most recently from d7460b2 to d2b7903 Compare August 18, 2026 11:48
@cassidyjames
cassidyjames requested a review from a team as a code owner August 21, 2026 15:26
@cassidyjames
cassidyjames force-pushed the fix/stale-table-filter-columns branch from d2b7903 to 35a5787 Compare August 21, 2026 15:26
@cassidyjames
cassidyjames force-pushed the fix/stale-table-filter-columns branch from 35a5787 to 3dd49f5 Compare August 21, 2026 15:33
@cassidyjames
cassidyjames force-pushed the fix/stale-table-filter-columns branch from 3dd49f5 to 8c827b8 Compare August 21, 2026 17:04
@taobojlen
taobojlen force-pushed the fix/stale-table-filter-columns branch from 8c827b8 to 2fc1098 Compare August 24, 2026 09:42
@taobojlen
taobojlen force-pushed the fix/stale-table-filter-columns branch from 2fc1098 to 4df660b Compare August 24, 2026 12:23
@cassidyjames
cassidyjames force-pushed the fix/stale-table-filter-columns branch from 4df660b to 3c43624 Compare August 26, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant