Handle filters for removed table columns - #1033
Open
taobojlen wants to merge 2 commits into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
taobojlen
force-pushed
the
fix/stale-table-filter-columns
branch
from
August 18, 2026 10:00
e018903 to
6892d2b
Compare
taobojlen
force-pushed
the
fix/stale-table-filter-columns
branch
from
August 18, 2026 10:13
6892d2b to
db651b6
Compare
taobojlen
force-pushed
the
fix/stale-table-filter-columns
branch
from
August 18, 2026 10:19
db651b6 to
1ebc995
Compare
taobojlen
marked this pull request as ready for review
August 18, 2026 11:38
taobojlen
requested review from
cassidyjames,
dom-notion,
juanmrad,
julietshen and
vinaysrao1
as code owners
August 18, 2026 11:38
taobojlen
force-pushed
the
fix/stale-table-filter-columns
branch
2 times, most recently
from
August 18, 2026 11:48
d7460b2 to
d2b7903
Compare
cassidyjames
force-pushed
the
fix/stale-table-filter-columns
branch
from
August 21, 2026 15:26
d2b7903 to
35a5787
Compare
cassidyjames
force-pushed
the
fix/stale-table-filter-columns
branch
from
August 21, 2026 15:33
35a5787 to
3dd49f5
Compare
cassidyjames
force-pushed
the
fix/stale-table-filter-columns
branch
from
August 21, 2026 17:04
3dd49f5 to
8c827b8
Compare
taobojlen
force-pushed
the
fix/stale-table-filter-columns
branch
from
August 24, 2026 09:42
8c827b8 to
2fc1098
Compare
taobojlen
force-pushed
the
fix/stale-table-filter-columns
branch
from
August 24, 2026 12:23
2fc1098 to
4df660b
Compare
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fec69-19ab-77e8-b6f0-85af1ed67eed
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fec69-19ab-77e8-b6f0-85af1ed67eed
cassidyjames
force-pushed
the
fix/stale-table-filter-columns
branch
from
August 26, 2026 21:53
4df660b to
3c43624
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
This PR fixes a kind of niche bug that CodeRabbit found. To repro it:
Before, this would crash. No more.
I'm unsure if this is worth the added complexity. What do you think?
Tests
Manually tested.
(Optional) Rollout Plan
N/A
Checklist
Only check items that apply to this PR; leave the rest unchecked.
If you changed anything user-facing (i.e. user interface or APIs):Did you update the CHANGELOG.md and related docs?
If you changedserver/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:Did you update the corresponding history tables and their triggers?
If you changeddb/src/scripts/**and usedCREATE TABLE,ADD COLUMN, orALTER COLUMN:Are as many columns marked
NOT NULLas possible? If some columns can sometimes be null depending on other columns, are thereCHECKconstraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?If you added a new signal inserver/services/signalsService/signals/**:Did you classify every error case as a permanent error (
SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be aSignalPermanentError.