Migrate to N-API (fixes #6)

[Jule-]

As mentioned it fixes #6, in other words it is working with Node V12.

[nikeee]

Is there anything that prevents this from merging?

[Jule-]

I don't know, no sign from @jorangreef since I have created it while I see that he continues telling people that he will do the N-API migration soon, likely by himself. I am disappointed, I tried to help...

[jorangreef]

Thanks @Jule- ! Sorry, somehow I missed this.

What I meant by moving to N-API, was moving to the pure C N-API, i.e. no more C++.

[Jule-]

@jorangreef no problem it happens. 😉

Why do you want to go for pure C N-API ? Is C++ node-addon-api not enough?

[jorangreef]

It's pure C :)

[edmundo096]

@jorangreef Do you think that we could use Jule-'s changes meanwhile the C version gets through?

I used Jule-'s commit (with npm i https://github.com/Jule-/utimes.git#napi-migration) and all went good enough, working correctly on node v12.3.1 on Win x64.

Off-topic: I see @jorangreef you have the @ronomon/queue as a dependency. I think this is used only by the testing script, so it could be moved to be a devDependency (npm i -D @ronomon/queue should do the trick).
This would make the package to have only 1 dependency, the node-addon-api.

Off-topic 2: Like to your profile pic @Jule- !

Great compact utility library by the way

[jorangreef]

Thanks @edmundo096 , I don't want to push a new release unless it's N-API, and you should be able to cherry pick that PR if needed?

Thanks for the dev dependency tip. I will do that in the next N-API release. I hope to get to this soon!

[Jule-]

I do not understand why not releasing a intermediate version...

Whatever, it could be interesting to see the pure C improvement and which application could benefit of this C implementation performance upgrade if it really exists. I am not an expert on the subject but IMHO you will hit drives bottleneck way before the C++ overhead if you are trying to batch parallelized file changes. Just curious.

Off-topic: Thanks @edmundo096! 😅

[jorangreef]

Thanks @Jule-,

It's not for performance. C is cleaner, especially using the N-API C library.

[Jule-]

Ok @jorangreef, looking forward to see your implementation! 🙂

Thanks again for this useful lib! 👍

[Offirmo]

Any news?

[jlindberg-oss]

Has anyone tried https://github.com/baileyherbert/utimes? Looks like it's trying to be a fork of this lib to support modern node versions.

[Jule-]

@jlindberg-oss nope, didn't test it but it seems he has took my compatibility changes so it should be ok.

@baileyherbert thanks for doing it, I have been so close to do it... 😅
And thanks for the credit! 😉

[Offirmo]

@jlindberg-oss I just tried https://github.com/baileyherbert/utimes and it works on latest macOs 👍