Skip to content

Conversation

@dasa
Copy link
Contributor

@dasa dasa commented Nov 27, 2024

Rollup Plugin Name: @rollup/replace

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Adds types for objectGuards which were missed in PR #1084.

@dasa dasa requested a review from shellscape as a code owner November 27, 2024 00:52
@dasa
Copy link
Contributor Author

dasa commented Nov 27, 2024

Sorry, I didn't notice @ikkz's PR #1817 until after I created this PR. Please close this if that PR is preferred.

@ikkz
Copy link
Contributor

ikkz commented Nov 27, 2024

I have closed mine. your code is more complete.

@shellscape shellscape merged commit 9c0efb0 into rollup:master Dec 15, 2024
5 checks passed
@dasa dasa deleted the replace-types branch December 16, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants