Added no-undef rule (#1419)

Author: matux

eslint.config.js

@@ -4,6 +4,7 @@ import { defineConfig } from 'eslint/config';
 import importPlugin from 'eslint-plugin-import';
 import prettierRecommended from 'eslint-plugin-prettier/recommended';
 import unusedImports from 'eslint-plugin-unused-imports';
+import globals from 'globals';
 
 export default defineConfig([
   js.configs.recommended,
@@ -52,8 +53,30 @@ export default defineConfig([
     },
   },
 
+  // globals
   {
-    files: ['**/*.{js,mjs}'],
+    files: ['test/**/*.js'],
+    languageOptions: { globals: { ...globals.mocha } },
+  },
+
+  {
+    files: ['src/**/*.{js,cjs}', 'test/**/*.js'],
+    languageOptions: { globals: { ...globals.browser } },
+  },
+
+  {
+    files: [
+      'src/server/**/*.js',
+      'src/react-native/**/*.js',
+      'test/**/server.*.js',
+      'scripts/**/*.js',
+    ],
+    languageOptions: { globals: { ...globals.node } },
+  },
+
+  // sources
+  {
+    files: ['**/*.js'],
     languageOptions: {
       sourceType: 'module',
       parser: babelParser,
@@ -64,26 +87,22 @@ export default defineConfig([
     rules: {
       strict: ['error', 'safe'],
       'no-prototype-builtins': 'off',
-      'no-undef': 'off',
     },
   },
 
+  // cjs
   {
     files: ['**/*.cjs'],
-    languageOptions: {
-      sourceType: 'commonjs',
-    },
-    rules: {
-      strict: 'off',
-    },
+    languageOptions: { sourceType: 'commonjs' },
+    rules: { strict: 'off' },
   },
 
+  // scripts
   {
-    files: ['scripts/**/*.{js,mjs,cjs}'],
-    rules: {
-      'no-console': 'off',
-    },
+    files: ['scripts/**/*.{js,cjs}'],
+    rules: { 'no-console': 'off' },
   },
+
   {
     ignores: ['dist', 'examples', 'node_modules', 'vendor', 'coverage'],
   },

package-lock.json

@@ -107,6 +107,7 @@
     "eslint-plugin-unused-imports": "^4.3.0",
     "express": "^4.21.2",
     "glob": "^5.0.14",
+    "globals": "^16.5.0",
     "mocha": "^11.1.0",
     "nock": "^11.9.1",
     "node-libs-browser": "^0.5.2",

package.json

@@ -151,28 +151,28 @@ describe('post', function () {
     it('should use fetch when requested', function (done) {
       var callback = function (err, _resp) {
         expect(window.fetchStub.called).to.be.ok;
-        expect(server.requests.length).to.eql(0);
+        expect(window.server.requests.length).to.eql(0);
         done(err);
       };
       stubFetchResponse();
       stubXhrResponse();
-      server.requests.length = 0;
+      window.server.requests.length = 0;
       options.transport = 'fetch';
       t.post({ accessToken, options, payload, callback });
     });
     it('should use xhr when requested', function (done) {
       var callback = function (err, _resp) {
         expect(window.fetchStub.called).to.not.be.ok;
-        expect(server.requests.length).to.eql(1);
+        expect(window.server.requests.length).to.eql(1);
         done(err);
       };
       stubFetchResponse();
       stubXhrResponse();
-      server.requests.length = 0;
+      window.server.requests.length = 0;
       options.transport = 'xhr';
       t.post({ accessToken, options, payload, callback });
       setTimeout(function () {
-        server.respond();
+        window.server.respond();
       }, 1);
     });
   });

test/browser.transport.test.js

@@ -1,7 +1,3 @@
-/* globals describe */
-/* globals it */
-/* globals beforeEach */
-
 import { expect } from 'chai';
 import sinon from 'sinon';
 

test/server.lambda.test.js

@@ -1,6 +1,3 @@
-/* globals describe */
-/* globals it */
-
 import { expect } from 'chai';
 
 import logger from '../src/logger.js';

test/server.locals.constructor.test.js

@@ -1,8 +1,3 @@
-/* globals describe */
-/* globals it */
-/* globals beforeEach */
-/* globals afterEach */
-
 import { expect } from 'chai';
 import sinon from 'sinon';
 
@@ -18,7 +13,7 @@ import {
   nodeThrowWithNestedLocals,
   nodeThrowRecursionError,
   verifyRejectedPromise,
-} from './server.locals.test-utils.mjs';
+} from './server.locals.test-utils.js';
 
 describe('server.locals error handling', function () {
   let mochaExceptionHandlers;

test/server.locals.error-handling.test.js

@@ -1,7 +1,3 @@
-/* globals describe */
-/* globals it */
-/* globals afterEach */
-
 import { expect } from 'chai';
 import sinon from 'sinon';
 

test/server.locals.merge.test.js

@@ -1,7 +1,3 @@
-/* globals describe */
-/* globals it */
-/* globals beforeEach */
-
 import { expect } from 'chai';
 
 import * as p from '../src/server/parser.js';