Enable no-unused-vars rule (#1418)

Author: matux

eslint.config.js

@@ -41,6 +41,14 @@ export default defineConfig([
           'newlines-between': 'always',
         },
       ],
+      'no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          caughtErrorsIgnorePattern: '^_',
+        },
+      ],
     },
   },
 
@@ -57,7 +65,6 @@ export default defineConfig([
       strict: ['error', 'safe'],
       'no-prototype-builtins': 'off',
       'no-undef': 'off',
-      'no-unused-vars': 'off',
     },
   },
 

src/browser/core.js

@@ -435,7 +435,7 @@ class Rollbar {
       }
 
       return f._rollbar_wrapped;
-    } catch (e) {
+    } catch (_e) {
       // Return the original function if the wrap fails.
       return f;
     }

src/browser/domUtility.js

@@ -161,7 +161,7 @@ function isMatchingElement(element, classes, selectors) {
         return true;
       }
     }
-  } catch (e) {
+  } catch (_e) {
     // ignore errors from invalid arguments
   }
   return false;

src/browser/globalSetup.js

@@ -67,12 +67,12 @@ function captureUnhandledRejections(window, handler, shim) {
     var reason, promise, detail;
     try {
       reason = evt.reason;
-    } catch (e) {
+    } catch (_e) {
       reason = undefined;
     }
     try {
       promise = evt.promise;
-    } catch (e) {
+    } catch (_e) {
       promise = '[unhandledrejection] error getting `promise` from event';
     }
     try {
@@ -81,7 +81,7 @@ function captureUnhandledRejections(window, handler, shim) {
         reason = detail.reason;
         promise = detail.promise;
       }
-    } catch (e) {
+    } catch (_e) {
       // Ignore
     }
     if (!reason) {

src/browser/replay/recorder.js

@@ -60,8 +60,8 @@ export default class Recorder {
       debug,
 
       // disallowed rrweb options
-      emit,
-      checkoutEveryNms,
+      emit: _emit,
+      checkoutEveryNms: _checkoutEveryNms,
 
       // rrweb options
       ...rrwebOptions

src/browser/replay/replay.js

@@ -231,7 +231,7 @@ export default class Replay {
 
     try {
       await this.send(replayId);
-    } catch (error) {
+    } catch (_error) {
       this.discard(replayId);
       return null;
     }

src/browser/shim.js

@@ -11,7 +11,7 @@ function _wrapInternalErr(f) {
     } catch (e) {
       try {
         logger.error('[Rollbar]: Internal error', e);
-      } catch (e2) {
+      } catch (_e2) {
         // Ignore
       }
     }
@@ -146,7 +146,7 @@ Shim.prototype.loadFull = function (
       s.onload = s.onreadystatechange = null;
       try {
         parentNode.removeChild(s);
-      } catch (e) {
+      } catch (_e) {
         // pass
       }
       done = true;
@@ -210,7 +210,7 @@ Shim.prototype.wrap = function (f, context, _before) {
     }
 
     return f._rollbar_wrapped;
-  } catch (e) {
+  } catch (_e) {
     // Return the original function if the wrap fails.
     return f;
   }

src/browser/telemetry.js

@@ -328,7 +328,7 @@ class Instrumenter {
                           headers[h] = xhr.getResponseHeader(h);
                         }
                       }
-                    } catch (e) {
+                    } catch (_e) {
                       /* we ignore the errors here that could come from different
                        * browser issues with the xhr methods */
                     }
@@ -337,7 +337,7 @@ class Instrumenter {
                   if (self.autoInstrument.networkResponseBody) {
                     try {
                       body = xhr.responseText;
-                    } catch (e) {
+                    } catch (_e) {
                       /* ignore errors from reading responseText */
                     }
                   }
@@ -374,7 +374,7 @@ class Instrumenter {
                     xhr.__rollbar_event.level =
                       self.telemeter.levelFromStatus(code);
                     self.errorOnHttpStatus(xhr.__rollbar_xhr);
-                  } catch (e) {
+                  } catch (_e) {
                     /* ignore possible exception from xhr.status */
                   }
                 }
@@ -415,7 +415,7 @@ class Instrumenter {
         this._window,
         'fetch',
         function (orig) {
-          return function (fn, t) {
+          return function (_fn, _t) {
             const args = [...arguments];
             const input = args[0];
             let method = 'GET';
@@ -586,7 +586,7 @@ class Instrumenter {
           outHeaders[h] = inHeaders.get(h);
         }
       }
-    } catch (e) {
+    } catch (_e) {
       /* ignore probable IE errors */
     }
     return outHeaders;
@@ -662,7 +662,6 @@ class Instrumenter {
   }
 
   instrumentDom() {
-    const self = this;
     this.addListener(
       'dom',
       this._window,
@@ -708,8 +707,8 @@ class Instrumenter {
     }
   }
 
-  handleContentLoaded(evt) {
-    const replayId = this.rollbar.triggerReplay({
+  handleContentLoaded(_evt) {
+    this.rollbar.triggerReplay({
       type: 'navigation',
       path: new URL(this._location.href).pathname,
     });
@@ -741,12 +740,12 @@ class Instrumenter {
     });
   }
 
-  handleForm(evt) {
+  handleForm(_evt) {
     // TODO: implement form event handling
-    const type = evt.type;
-    const elementString = evt.target?.window
-      ? 'window'
-      : domUtil.elementString(evt.target);
+    //const type = evt.type;
+    //const elementString = evt.target?.window
+    //  ? 'window'
+    //  : domUtil.elementString(evt.target);
   }
 
   handleResize(evt) {
@@ -958,7 +957,7 @@ class Instrumenter {
       from = parsedFrom.path + (parsedFrom.hash || '');
     }
     this.telemeter.captureNavigation(from, to, null, _.now());
-    const replayId = this.rollbar.triggerReplay({
+    this.rollbar.triggerReplay({
       type: 'navigation',
       path: to,
     });

src/browser/transport/xhr.js

@@ -97,7 +97,7 @@ function makeXhrRequest({
 
       request.onreadystatechange = onreadystatechange;
       request.send(payload);
-    } catch (e1) {
+    } catch (_e1) {
       // Sending using the normal xmlhttprequest object didn't work, try XDomainRequest
       if (typeof XDomainRequest !== 'undefined') {
         // Assume we are in a really old browser which has a bunch of limitations:
@@ -169,7 +169,7 @@ function _createXMLHTTPObject() {
     try {
       xmlhttp = factories[i]();
       break;
-    } catch (e) {
+    } catch (_e) {
       // pass
     }
   }

src/errorParser.js

@@ -37,7 +37,7 @@ function Stack(exception, skip) {
 
     try {
       parserStack = parseErrorStack(exception);
-    } catch (e) {
+    } catch (_e) {
       parserStack = [];
     }