Adds -allow-implicit for type annotations #133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the
type-annotations
rule to addall-allow-implicit
andargs-allow-implicit
so when an argument has a default value, it is not flagged by the rule:Before:
![image](https://private-user-images.githubusercontent.com/810290/367765918-2646254b-50d9-4e28-9eb4-d9b4c2688680.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDE2MzEsIm5iZiI6MTczOTYwMTMzMSwicGF0aCI6Ii84MTAyOTAvMzY3NzY1OTE4LTI2NDYyNTRiLTUwZDktNGUyOC05ZWI0LWQ5YjRjMjY4ODY4MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNjM1MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NGNiOWJhYjVlZDg5MjhiN2E3NWE5ZjlkZmM3ZmI3YzNmMDVlODRkMmRjNjM0YmJlZGY3MjQxNTBiZmZhMzk0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Em6Zak1kD-w1d5o-UCPUrau5hwW2_B4pbx59abGfQJ0)
After:
![image](https://private-user-images.githubusercontent.com/810290/367766445-dc0451aa-86b6-43cb-87ed-a89efd6aa994.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDE2MzEsIm5iZiI6MTczOTYwMTMzMSwicGF0aCI6Ii84MTAyOTAvMzY3NzY2NDQ1LWRjMDQ1MWFhLTg2YjYtNDNjYi04N2VkLWE4OWVmZDZhYTk5NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNjM1MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03N2MyYWM3NTA2N2RlM2YwOGE0ZjJjYzNjYTVmMjYyMDE3NTIzMTAyYmQ4MTkxOTkwZTg0M2NhMTgzM2I1MWI3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.O3cLbj7n2B8inuu7Snw7FfEsTrlf5fWk-bPV2puOtB0)