Use FontFace and consistent text sizing #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boatbomber
added
scope: plugin
Dekkonot
reviewed
Nov 7, 2024
boatbomber
removed
the
skip changelog
Dekkonot
approved these changes
Nov 9, 2024
kennethloeffler
requested changes
Nov 9, 2024
kennethloeffler
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Gothamfont we use no longer exists. This PR upgrades to usingFontFace, and also unifies our styling by putting fonts and text sizes intoThemeinstead of hardcoding them inline. This will make it easier to adjust our UI in the future (or perhaps add accessibility settings).It's pretty much identical to before, but all the text sizes are consistent (no more 14 vs 15) and the notifs and tooltips are better at getting the correct text bounds (no cutting off edge cases anymore).