Skip to content

Conversation

@ari-party
Copy link

The Instance.Name property famously doesn't support special characters. E.g. a forward slash (/).
This causes you to be unable to have any instances in your Rojo project with special characters.

This PR:

  • Adds preference for name from .meta and .model.json files when syncing
  • Syncback now slugifies (replaces invalid characters with _) and adds the name property if slugified version doesn't equal original

@ari-party
Copy link
Author

Noticed that RemoteEvents are written as .rbxm
Intended? Or should get_best_middleware be updated?
I feel like JsonModel should be the default, and using .rbxm for specific classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant