Refactor MaterialColors to Array #576
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does MaterialColors use a BTreeMap? The entire data structure
[Color3uint8;21](63 bytes) can fit into a Variant (64 bytes) on the stack. The FromIterator and IntoIterator stuff added here is neat, but the serde implementation is no longer derivable. Encode and decode could be be made into a single unsafe transmute, but this is not performance critical code so whatever.Notes:
From<T:Into<BTreeMap>>is no longer supported, butFromIterator<(TerrainMaterials, Color3uint8)>can be used instead, and arguably should have been used in the first place.