Skip to content

fix(mcp): pin matching core package version - #1231

Open
cmondragon023 wants to merge 1 commit into
rohitg00:mainfrom
cmondragon023:fix/mcp-pin-matching-core-version
Open

fix(mcp): pin matching core package version#1231
cmondragon023 wants to merge 1 commit into
rohitg00:mainfrom
cmondragon023:fix/mcp-pin-matching-core-version

Conversation

@cmondragon023

@cmondragon023 cmondragon023 commented Aug 20, 2026

Copy link
Copy Markdown

Summary

  • pin @agentmemory/mcp@0.9.29 to the exact matching @agentmemory/agentmemory@0.9.29 core package
  • extend the existing package consistency test so future release bumps fail unless the shim version, root version, and core dependency stay synchronized

Closes #668

Testing

  • node_modules/.bin/vitest run test/consistency.test.ts — 9 tests passed
  • node_modules/.bin/vitest run --exclude test/integration.test.ts — 151 test files passed, 1 skipped; 1,657 tests passed, 1 skipped
  • git diff --check

Summary by CodeRabbit

  • Bug Fixes
    • Improved package version consistency by pinning the MCP package dependency to the exact matching release.
  • Tests
    • Added validation to ensure the MCP dependency version stays aligned with the root package version.

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

@cmondragon023 is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 91a02046-acf4-4710-83c8-0c1e05a171ae

📥 Commits

Reviewing files that changed from the base of the PR and between 2d38daf and 5736de6.

📒 Files selected for processing (2)
  • packages/mcp/package.json
  • test/consistency.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The MCP package now pins @agentmemory/agentmemory to 0.9.29. The consistency test verifies that this dependency matches the root package version.

Changes

MCP version alignment

Layer / File(s) Summary
Pin dependency and validate version alignment
packages/mcp/package.json, test/consistency.test.ts
The MCP package pins @agentmemory/agentmemory to 0.9.29. The consistency test checks the dependency against the root package version.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 5736d

This localized change keeps the MCP and core package versions synchronized and adds coverage to prevent future mismatches; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: rohitg00

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes pinning the MCP package to the matching core package version.
Linked Issues check ✅ Passed The changes pin the core dependency to 0.9.29 and add a consistency test, satisfying issue #668.
Out of Scope Changes check ✅ Passed All changes are limited to the MCP dependency and its version consistency test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@agentmemory/mcp does not pin the matching core version, allowing fixed MCP behavior to regress

1 participant