collapse_sort_variables rename and flip to_type argument to only_above_prop and make it non implicit#21820
Merged
coqbot-app[bot] merged 3 commits intorocq-prover:masterfrom Mar 31, 2026
Merged
Conversation
SkySkimmer
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
added
the
needs: overlay
SkySkimmer
added a commit
to SkySkimmer/coq-elpi
that referenced
this pull request
Mar 26, 2026
SkySkimmer
added a commit
to SkySkimmer/Coq-Equations
that referenced
this pull request
Mar 26, 2026
We do Evd.minimize with default poly just above so sort variables are already collapsed.
SkySkimmer
added a commit
to SkySkimmer/Mtac2
that referenced
this pull request
Mar 26, 2026
SkySkimmer
added a commit
to SkySkimmer/coq-waterproof
that referenced
this pull request
Mar 26, 2026
SkySkimmer
added a commit
to SkySkimmer/rewriter
that referenced
this pull request
Mar 26, 2026
SkySkimmer
added
request: full CI
coqbot-app
bot
removed
the
request: full CI
github-actions
bot
added
the
needs: rebase
…e_prop This is easier to understand and more accurate to what the flag does IMO.
coqbot-app
bot
added
needs: full CI
Contributor
Author
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
Member
|
@coqbot merge now |
Contributor
|
@ppedrot: Please take care of the following overlays:
|
ppedrot
added a commit
to rocq-prover/equations
that referenced
this pull request
Mar 31, 2026
Adapt to rocq-prover/rocq#21820 (collapse_sort_variables arg change)
jim-portegies
added a commit
to impermeable/coq-waterproof
that referenced
this pull request
Mar 31, 2026
Adapt to rocq-prover/rocq#21820 (collapse_sort_variables arg change)
Janno
added a commit
to Mtac2/Mtac2
that referenced
this pull request
Mar 31, 2026
Adapt to rocq-prover/rocq#21820 (collapse_sort_variables arg change)
ppedrot
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Mar 31, 2026
Adapt to rocq-prover/rocq#21820 (collapse_sort_variables arg is not implicit)
JasonGross
pushed a commit
to SkySkimmer/rewriter
that referenced
this pull request
Apr 1, 2026
JasonGross
pushed a commit
to mit-plv/rewriter
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is easier to understand and more accurate to what the flag does IMO.
The default value was only used in 2 places (Check and template processing) so does not seem worth keeping.
Overlays: