Gentactic hide that the underlying implem is genarg based#21568
Merged
coqbot-app[bot] merged 4 commits intorocq-prover:masterfrom Feb 2, 2026
Merged
Gentactic hide that the underlying implem is genarg based#21568coqbot-app[bot] merged 4 commits intorocq-prover:masterfrom
coqbot-app[bot] merged 4 commits intorocq-prover:masterfrom
Conversation
register_interp0 is in geninterp not genintern
SkySkimmer
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
added a commit
to SkySkimmer/coq-tactician
that referenced
this pull request
Jan 30, 2026
SkySkimmer
added a commit
to SkySkimmer/Mtac2
that referenced
this pull request
Jan 30, 2026
SkySkimmer
added a commit
to SkySkimmer/coq-waterproof
that referenced
this pull request
Jan 30, 2026
SkySkimmer
added
the
request: full CI
We stop exposing the genargs used by gentactic as being genargs and instead put them in abstract type Gentactic.tag. In principle we should be able to define our own Dyn and tables instead of using genargs (we now define our own table for interp because we want another type).
coqbot-app
bot
removed
the
request: full CI
ppedrot
reviewed
Jan 30, 2026
| toplevel interpretation. The one of [wit_ltac] forces the tactic and | ||
| discards the result. *) | ||
| val wit_ltac : (raw_tactic_expr, glob_tactic_expr, unit) genarg_type | ||
| val wit_ltac : (raw_tactic_expr, glob_tactic_expr) Gentactic.tag |
Member
There was a problem hiding this comment.
I'm a bit surprised we don't use this type for its genarg but only its gentactic tag...
Member
I think this should be part of this PR. I wanted to do this for a while in order to kick Ftactic out of the core library into the Ltac plugin. |
Contributor
Author
|
ok |
SkySkimmer
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
ppedrot
approved these changes
Feb 2, 2026
Member
|
@coqbot merge now |
Contributor
|
@ppedrot: Please take care of the following overlays:
|
Janno
added a commit
to Mtac2/Mtac2
that referenced
this pull request
Feb 2, 2026
Adapt to rocq-prover/rocq#21568 (gentactic is not genarg)
jim-portegies
added a commit
to impermeable/coq-waterproof
that referenced
this pull request
Feb 2, 2026
Adapt to rocq-prover/rocq#21568 (gentactic is not genarg)
LasseBlaauwbroek
added a commit
to coq-tactician/coq-tactician
that referenced
this pull request
Feb 2, 2026
Adapt to rocq-prover/rocq#21568 (gentactic is not genarg)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We stop exposing the genargs used by gentactic as being genargs and
instead put them in abstract type Gentactic.tag.
In principle we should be able to define our own Dyn and tables instead of
using genargs (we now define our own table for interp because we want another type).
Overlays: