add initial replacement for files.upload #126
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes only the
files.uploadcall that we have been using. It's minimal to begin with. Some of the help documentation likely will have to be updated, as well as some of the additional code in thefileupload()function, particularly cases which are potentially no longer relevant.The new
files.getUploadURLExternalendpoint requires alengthparameter, which seems quite tricky to implement in a very portable and efficient way. I went withwc -c < ${_file} | xargsbecause it seems to be the most cross-platform, but may be slow.The new
files.completeUploadExternalendpoint only accepts Channel IDs (and not channel names), which is a potentially significant usage change.