feat(custom-mutators): maintain and fork ivm through pull, mutate, refresh #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Bencher Report| Branch | mlaw/call-zero-option |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 1,007.19 KB(+0.17%)Baseline: 1,005.50 KB | 1,025.61 KB (98.20%) |
| zero.js | 📈 view plot 🚷 view threshold | 181.82 KB(+0.26%)Baseline: 181.34 KB | 184.97 KB (98.30%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 50.80 KB(+0.34%)Baseline: 50.63 KB | 51.64 KB (98.38%) |
tantaman
force-pushed
the
mlaw/call-zero-option
branch
from
a3ca3a4 to
d04f2d4
Compare
tantaman
force-pushed
the
mlaw/call-zero-option
branch
from
fc4777e to
d244a22
Compare
tantaman
commented
Mar 7, 2025
| @@ -65,6 +66,7 @@ export async function persistDD31( | |||
| mutators: MutatorDefs, | |||
| closed: () => boolean, | |||
| formatVersion: FormatVersion, | |||
| _getZeroData: ZeroOption['getTxData'] | undefined, | |||
There was a problem hiding this comment.
to be used in the next PR. Getting persist to work requires changes to LazyRead and LazyStore which wouldn't fit well to be reviewed in this context.
tantaman
force-pushed
the
mlaw/call-zero-option
branch
from
ed66b00 to
e6fe7ee
Compare
tantaman
force-pushed
the
mlaw/call-zero-option
branch
from
e6fe7ee to
375f2e1
Compare
…ot provided If the user of Zero has not defined any custom mutators, do not fork the IVM sources and return `undefined` instead. This is mainly a safety thing. We want there to be a minimal chance of breaking existing users while we're still stabilizing custom mutators. CRUD mutators also do not need forks of the IVM sources since they do not issue reads during mutations.
tantaman
force-pushed
the
mlaw/call-zero-option
branch
from
375f2e1 to
ccbfca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist requires some more invasive changes and will be in a separate PR.
Calls to
advanceare the key thing to review.advancereplaces our use ofexperimentalWatchto update the main IVM sources. The main difference from experimentalWatch is thatadvancesends in the expected hash we're advancing from and the hash we're advancing to. This allowsadvanceto set an invariant that we always advance in order. The IVMBranch also keeps track of its current hash so it can compute diffs to use to patch forks inforkToHead(hash).I'm surprised we never ran into problems with
experimentalWatchas I would imagine there would have been cases where arefreshdiff against HEAD-1 jumps ahead of apullEnddiff against HEAD-0 (due to awaits) or vice-versa.