Improve experience for unhandled parse errors #7203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few unhandled syntax errors have accumulated over the years. It's easy to forget to handle these in reporting because we have wildcard
match
branches that just calltodo!()
:That experience is pretty bad when you hit one. You don't know which file the error is in, and you only get byte offsets instead of a line and column.
We should handle all of those, but in the meantime, this PR removes all wildcard pattern matching on parser errors to prevent more cases from accumulating.
Furthermore, it improves the experience for the existing unhandled cases by printing a more intentional report that includes the file and region:
Let me know what you think of that note. I thought it was a nice opportunity to encourage contributions, but I'm happy it to drop it if we don't want the compiler to do that.