Fixed broken link for doc search on ios #7196
Open
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still not quite working for me on Safari. It works as expected on Chrome.
|
lukewilliamboswell
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
@jfkonecn I rebuilt roc from this branch and tried this again. It's working in safari. I must have messed something up when I tested it the first time.
I'm glad because I was out of ideas on how to fix it. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the link no working on search results on ios.
Seems like ios's focus-within event doesn't work quite right so I changed the css so it doesn't use it.