Skip to content

Mocha reports variable leaks into global scope #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mocha reports variable leaks into global scope #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d4a10d
Fix leak of util variable into global scope.
forissier Mar 14, 2013
b0911c7
Fix more leaks of variables into global namespace.
forissier Mar 14, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/node-xml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,14 +273,14 @@ XMLP.prototype._parse = function() {

////////// NAMESPACE SUPPORT //////////////////////////////////////////
XMLP.prototype._parsePrefixAndElementName = function (elementlabel){
splits = elementlabel.split(':',2);
var splits = elementlabel.split(':',2);
return { prefix : ((splits.length === 1) ? '' : splits[0]), name : ((splits.length === 1) ? elementlabel : splits[1]), };
}

XMLP.prototype._parseNamespacesAndAtts = function (atts){
//translate namespaces into objects with "prefix","uri", "scopetag" Add them to: this.m_namespaceList
//The function should return a new list of tag attributes with the namespaces filtered
that = this;
var that = this;
var newnamespaces = [];
var filteredatts = [];
atts.map(function (item){
Expand Down Expand Up @@ -339,7 +339,7 @@ XMLP.prototype._removeExpiredNamesapces = function (closingtagname) {


XMLP.prototype._parseAttribute = function(iB, iE) {
var iNB, iNE, iEq, iVB, iVE;
var iNB, iNE, iEq, iVB, iVE, iRet;
var cQuote, strN, strV;

this.m_cAlt = ""; //resets the value so we don't use an old one by accident (see testAttribute7 in the test suite)
Expand Down Expand Up @@ -480,7 +480,7 @@ XMLP.prototype._parseDTD = function(iB) {
}

XMLP.prototype._parseElement = function(iB) {
util = require('util');
var util = require('util');
var iE, iDE, iNE, iRet;
var iType, strN, iLast;

Expand Down Expand Up @@ -634,7 +634,7 @@ XMLP.prototype._replaceEntities = function(strD, iB, iE) {
iE = iE || strD.length;


var iEB, iEE, strRet = "";
var iEB, iEE, strRet = "", iRet;

iEB = strD.indexOf("&", iB);
iEE = iB;
Expand Down Expand Up @@ -805,7 +805,7 @@ SaxParser.prototype.parseFile = function(filename) { //This function will only w


SaxParser.prototype.parseString = function(strD) {
util = require('util');
var util = require('util');
var that = this;
var startnew = true;
if(!that.m_parser){
Expand Down Expand Up @@ -978,7 +978,7 @@ SaxParser.prototype._fireEvent = function(iEvt) {


SaxParser.prototype._parseLoop = function(parser) {
var iEvent, parser;
var iEvent, parser, theattsandnamespace, theatts, nameobject;

parser = this.m_parser;
while(!this.m_bErr) {
Expand Down