Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): 🚀 min and max supervision package requirements are added #566

Merged
merged 5 commits into from
Dec 4, 2023
Merged

build(deps): 🚀 min and max supervision package requirements are added #566

merged 5 commits into from
Dec 4, 2023

Conversation

onuralpszr
Copy link
Collaborator

No description provided.

@onuralpszr onuralpszr added the dependencies Pull requests that update a dependency file label Nov 2, 2023
@onuralpszr onuralpszr requested a review from SkalskiP November 2, 2023 19:17
@onuralpszr onuralpszr self-assigned this Nov 2, 2023
@onuralpszr onuralpszr changed the title build(deps: 🚀 min and max supervision package requirements are added build(deps): 🚀 min and max supervision package requirements are added Nov 2, 2023
@onuralpszr
Copy link
Collaborator Author

@SkalskiP I did not lowered extreme but try keep in reason and also check other deps but I only focused on "requirements" for development I assume you have proper machine can install latest dev tools and packages

@SkalskiP
Copy link
Collaborator

SkalskiP commented Nov 3, 2023

Hi @onuralpszr 👋🏻 Have you perhaps had a chance to test supervision with minimal dependencies?

@onuralpszr
Copy link
Collaborator Author

@SkalskiP I added CI for that already ? please check CI list

@onuralpszr
ci: 👷 ci job are renamed
583ad5f 
Signed-off-by: Onuralp SEZER <[email protected]>
@SkalskiP
Copy link
Collaborator

Hi, @onuralpszr 👋🏻 Is it ready for merge? I see some poetry.lock conflicts.

@onuralpszr
Copy link
Collaborator Author

Hi, @onuralpszr 👋🏻 Is it ready for merge? I see some poetry.lock conflicts.

Let me solve conflict

@onuralpszr
Copy link
Collaborator Author

onuralpszr commented Nov 15, 2023 •
edited
Loading

@SkalskiP I fix the py12 version control so instead of merge py12 PR I can configure versions for py12 in here and that will set our max version of python to python 3.12 and latest version of packages. So If you okay with idea. I would like to include in here for py12 support as well.

@SkalskiP
Copy link
Collaborator

SkalskiP commented Dec 4, 2023

@onuralpszr, there is a conflict in poetry.lock. Could you take a look?

@onuralpszr
Copy link
Collaborator Author

@onuralpszr, there is a conflict in poetry.lock. Could you take a look?

I am fixing it okay

@onuralpszr
Copy link
Collaborator Author

@SkalskiP conflict solved.

@SkalskiP
Copy link
Collaborator

SkalskiP commented Dec 4, 2023

Thanks a lot, @onuralpszr 🙏🏻 Let's test it out! Merging.

@SkalskiP SkalskiP merged commit b1ac5bc into develop Dec 4, 2023
5 checks passed
@SkalskiP SkalskiP deleted the min-ver-settings branch January 2, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkalskiP SkalskiP SkalskiP approved these changes

Assignees

@onuralpszr onuralpszr

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onuralpszr @SkalskiP