Repository navigation
fix(web): use intrinsic static image dimensions - #126
Draft
MohamedRed wants to merge 1 commit into
Draft
MohamedRed wants to merge 1 commit into
MohamedRed wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An HTML image styled smaller than its decoded pixels currently reports its layout size as the media size, affecting drawing and annotation coordinates. The advertised
VideoFrameinput also fails because it exposes display dimensions rather than generic width/height.Prefer HTML image intrinsic dimensions and VideoFrame display dimensions, validate finite positive sizes, and retain the existing canvas/bitmap handling and caller ownership.
Type of Change
Validation
1c9ec15:VITEST_MAX_WORKERS=2 npm run verifypassed (2,885 tests), as did tarball packaging and all 12 external-consumer checks.Notes For Reviewers
VideoFrame display dimensions already account for native rotation and aspect ratio. The corrected dimensions can change rendering for consumers relying on image layout size; an explicit canvas/host-drawn size remains available.
Open PR #121 touches the adapter and tarball test with separate clock-reason/license-notice additions; its current hunks do not implement this fix.
AI assistance: Prepared with OpenAI Codex assistance.