Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new validations to the basket functionality by adding unit price validation and reorganizing imports.
- Adds validation for negative unit prices in BasketItem
- Reorders using statements in BasketService for better organization
- Adds a hardcoded picture URL to basket item mapping
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Basket.API/Model/BasketItem.cs | Adds validation to prevent negative unit prices |
| src/Basket.API/Grpc/BasketService.cs | Reorders imports and adds hardcoded picture URL to basket items |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor bug fix and validation improvement to the basket service. The main updates are the addition of a default image URL for basket items and enhanced validation for negative unit prices.
Basket item enhancements:
PictureUrl("http://mypictures/demo.jpg") to each item when mapping to aCustomerBasketinBasketService.csto ensure items always have an image.Validation improvements:
BasketItemvalidation to add an error ifUnitPriceis negative, improving data integrity. The error message is in German: "Unit Preis muss grösser als null sein".Code cleanup:
BasketService.csfor better organization.