Skip to content

Add ID Validation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robinmanuelthiel wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add ID Validation #65

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
492f906
feat: add validation method for ID in basekt item
robinmanuelthiel Sep 4, 2025
3fb9b7d
fix: Error message is now in english
robinmanuelthiel Sep 4, 2025
2324b65
feat: Also validate product id
robinmanuelthiel Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Basket.API/Model/BasketItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@ public IEnumerable<ValidationResult> Validate(ValidationContext validationContex
results.Add(new ValidationResult("Invalid number of units", new[] { "Quantity" }));
}

// New validation for Id
if (string.IsNullOrWhiteSpace(Id))
{
results.Add(new ValidationResult("Id must not be empty", new[] { "Id" }));
}

// New validation for Id
if (string.IsNullOrWhiteSpace(ProductId.ToString()))
{
results.Add(new ValidationResult("Quantity must not be empty", new[] { "ProductId" }));
Copy link

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message incorrectly references 'Quantity' when validating ProductId. It should be 'ProductId must not be empty' instead.

Suggested change
results.Add(new ValidationResult("Quantity must not be empty", new[] { "ProductId" }));
results.Add(new ValidationResult("ProductId must not be empty", new[] { "ProductId" }));

Copilot uses AI. Check for mistakes.
Comment on lines +28 to +31
Copy link

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ToString() on ProductId will never return null or whitespace since ToString() always returns a string representation. For GUID validation, check if ProductId equals Guid.Empty instead.

Suggested change
// New validation for Id
if (string.IsNullOrWhiteSpace(ProductId.ToString()))
{
results.Add(new ValidationResult("Quantity must not be empty", new[] { "ProductId" }));
// New validation for ProductId
if (ProductId <= 0)
{
results.Add(new ValidationResult("ProductId must be a positive integer", new[] { "ProductId" }));

Copilot uses AI. Check for mistakes.
}

return results;
}
}