Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a new rule to validate that the old unit price is lower than the current unit price.
- Introduces a check in
BasketItem.Validateto compareOldUnitPriceandUnitPrice - Returns a validation error when the price rule is violated
Comments suppressed due to low confidence (1)
src/Basket.API/Model/BasketItem.cs:22
- Add unit tests for this new validation rule to ensure it correctly enforces that
OldUnitPrice < UnitPriceunder various scenarios.
if (OldUnitPrice >= UnitPrice)
|
|
||
| if (OldUnitPrice >= UnitPrice) | ||
| { | ||
| results.Add(new ValidationResult("Der Preis ist zu heiß!", new[] { "OldUnitPrice", "UnitPrice" })); |
There was a problem hiding this comment.
Error message is in German and inconsistent with the existing English messages; consider using a clear English message like "UnitPrice must be greater than OldUnitPrice".
Suggested change
| results.Add(new ValidationResult("Der Preis ist zu heiß!", new[] { "OldUnitPrice", "UnitPrice" })); | |
| results.Add(new ValidationResult("UnitPrice must be greater than OldUnitPrice", new[] { "OldUnitPrice", "UnitPrice" })); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a validation improvement to the
BasketItemmodel in theBasket.APIproject. It adds a new condition to ensure that theOldUnitPriceis not greater than or equal to theUnitPrice.Validation improvements:
src/Basket.API/Model/BasketItem.cs: Added a validation check to theValidatemethod that triggers an error message ("Der Preis ist zu heiß!") ifOldUnitPriceis greater than or equal toUnitPrice.