-
-
Notifications
You must be signed in to change notification settings - Fork 5
pre-release: beta.1 [DO NOT MERGE] #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
WalkthroughThe release workflow was updated to publish a single Docker image tag (2025.2-beta.1) to both Docker Hub and GitHub Container Registry. Previous multiple tags (latest, version, year variants) were removed. No other steps or logic in the workflow were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/release.yml (2)
148-153
: Avoid hardcoding the Docker tag; use the computed release version output.You already compute
steps.values.outputs.version
from the release tag, but the Docker tags are hardcoded to2025.2-beta.1
. This risks drift if the release tag changes or for future pre-releases. Use the computed version for both registries.Apply this diff to parameterize the image tags:
tags: | - spiralscout/velox:2025.2-beta.1 - ghcr.io/roadrunner-server/velox:2025.2-beta.1 + spiralscout/velox:${{ steps.values.outputs.version }} + ghcr.io/roadrunner-server/velox:${{ steps.values.outputs.version }}Also applies to: 165-166
165-166
: Confirm intent to publish only a single pre-release tag.Double-check that not publishing auxiliary tags (e.g.,
2025.2-beta
as a moving channel, orlatest
) is intentional for this pre-release. If you want a moving beta channel, we can derive it from the version and add it alongside the exact patch tag.If desired, I can provide a follow-up patch that computes a
beta
channel tag (e.g.,2025.2-beta
) from${{ steps.values.outputs.version }}
and adds it to thetags:
list.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/release.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build docker image
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit