Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): keep layer reference when reordering #3577

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

grantsisson
Copy link
Contributor

@grantsisson grantsisson commented Jul 29, 2024

Description

Fixes #3572 per #3572 (comment). Happy to validate other cases + new arch/v11 if this change seems sufficient. From the discussion seems it should be. Works for my simple bug report.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Screenshot_20240728_222554

Component to reproduce the issue you're fixing

See issue

@grantsisson
Copy link
Contributor Author

Is a dev dependency missing?

Error: Cannot find module '@babel/helper-split-export-declaration'

@grantsisson grantsisson temporarily deployed to CI with Mapbox Tokens August 6, 2024 18:19 — with GitHub Actions Inactive
@grantsisson grantsisson temporarily deployed to CI with Mapbox Tokens August 6, 2024 18:19 — with GitHub Actions Inactive
@grantsisson grantsisson temporarily deployed to CI with Mapbox Tokens August 6, 2024 18:19 — with GitHub Actions Inactive
@grantsisson grantsisson temporarily deployed to CI with Mapbox Tokens August 6, 2024 18:19 — with GitHub Actions Inactive
@grantsisson grantsisson temporarily deployed to CI with Mapbox Tokens August 6, 2024 18:19 — with GitHub Actions Inactive
@grantsisson grantsisson temporarily deployed to CI with Mapbox Tokens August 6, 2024 18:19 — with GitHub Actions Inactive
@grantsisson grantsisson temporarily deployed to CI with Mapbox Tokens August 6, 2024 18:19 — with GitHub Actions Inactive
@mfazekas
Copy link
Contributor

@grantsisson

Is a dev dependency missing?

Error: Cannot find module '@babel/helper-split-export-declaration'

Yes we don't have yarn.lock, we should probably have it

See:
https://github.com/rnmapbox/maps/pull/3585/files
for fix of build for now

@mfazekas mfazekas merged commit 22155a1 into rnmapbox:main Aug 10, 2024
10 of 11 checks passed
@grantsisson
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unexpected behavior with belowLayerID on Android
2 participants