Add source_video link field to PoseEstimation#56
Open
h-mayorquin wants to merge 1 commit intorly:mainfrom
Open
Add source_video link field to PoseEstimation#56h-mayorquin wants to merge 1 commit intorly:mainfrom
source_video link field to PoseEstimation#56h-mayorquin wants to merge 1 commit intorly:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
source_videolink toImageSeriesonPoseEstimation, consistent with howTrainingFramealready links to its source video. This provides a formal NWB reference to the source video instead of relying on the string paths inoriginal_videos, which can become stale or break when files are moved (e.g., dandi/dandi-cli#1817).Closes #12 and supersedes #13 with a simpler approach that requires no custom IO mapper.
To discuss: the current approach keeps
original_videosis kept for backwards compatibility but I am unsure if we should remove this and bumpb the schema source. I think we can leep it here and decide this later