fix(deps): cap transformers <5 until vLLM compatibility#443
Open
rajatbeladiya wants to merge 1 commit intorllm-org:mainfrom
Open
fix(deps): cap transformers <5 until vLLM compatibility#443rajatbeladiya wants to merge 1 commit intorllm-org:mainfrom
rajatbeladiya wants to merge 1 commit intorllm-org:mainfrom
Conversation
Transformers 5.0 can break older vLLM stacks used by verl/rllm (e.g. missing tokenizer attrs). Add an upper bound to avoid incompatible installs. Fixes rllm-org#388.
rajatbeladiya
force-pushed
the
fix/pin-transformers-v5-incompat-388
branch
from
063b200 to
b6eb3d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #388: Transformers 5.0.0 can be auto-installed due to an open-ended lower bound, but older vLLM stacks used via verl can be incompatible (e.g. tokenizer attribute errors).
This PR adds an upper bound to prevent installing Transformers v5 until the dependency stack is confirmed compatible.
Fixes #388