-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducting new variable GITHUB_EVENT_PULL_REQUEST_HEAD_SHA_SHORT #46
Introducting new variable GITHUB_EVENT_PULL_REQUEST_HEAD_SHA_SHORT #46
Conversation
Hello, I think you can simplify this by using |
Indeed. I am so bad with JavaScript, sorry about that 😬 |
No need to be sorry about that, me too i'm not fluent in Javascript. |
I may have messed up with the rebase. I made a clean branch |
@MadJlzz I can't change the branch in your PR. You can fix the
|
@rlespinasse done! Don't know why but the linting still fails. Even some piece that I didn't touch |
Since we use Prettier as formatter, the linter need more configuration to correctly manage this. I will merge this PR. |
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR solves #45
@rlespinasse
I had some hard time testing to be honnest (and I am still not sure the right way to test that unless running the action directly on GitHub)
I added 2 dependencies:
@actions/github
is used to get the context of why an action was triggered@octokit/webhooks
to get the typings forWebhookPayloadPullRequest
Sadly, all typings are not present in
@action/core
😭There is a reference to add it to the toolkit library for action here.
For linting errors, I let you tell me which tool you are using for that so that I can fix any errors that will surely show up in the pipeline. (and I will add that in
DEVELOPERS.md
as well 😀)