fix unhandled promise rejection asBuffer() take 2

Refs #312

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [2.5.2]
+### Fixed
+- Fixed unhandled promise rejection in `doc.asBuffer()` - take two
+
 ## [2.5.1]
 ### Fixed
 - Fixed unhandled promise rejection in `doc.asBuffer()`

lib/document.js

@@ -653,7 +653,7 @@ class Document extends Readable {
       this.on("end", () => resolve(Buffer.concat(chunks)));
       this.on("error", reject);
       if (shouldEnd) {
-        return this.end();
+        this.end().catch(reject);
       }
     });
     if (typeof callback === "function") {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "pdfjs",
   "author": "Markus Ast <[email protected]>",
-  "version": "2.5.1",
+  "version": "2.5.2",
   "description": "A Portable Document Format (PDF) generation library targeting both the server- and client-side.",
   "keywords": [
     "pdf",

test/others/asBuffer.js

@@ -45,3 +45,22 @@ test("asBuffer", function (t) {
     })
     .catch(t.error);
 });
+
+test("error in pending queue", async function (t) {
+  t.plan(1);
+
+  let doc = new pdf.Document({
+    font: f.font.afm.regular,
+  });
+
+  doc._pending.push(() => {
+    return new Promise(() => {
+      throw new Error("Test Error");
+    });
+  });
+
+  await doc
+    .asBuffer()
+    .then(() => t.fail("asBuffer expected to reject"))
+    .catch(() => t.pass("as Buffer rejected"));
+});