Persist mini-server deploy image#81
Conversation
The mini-server compose file falls back to latest when FAIRPLAY_BACKEND_IMAGE is absent from the server .env. Persist the GitHub SHA image during deploy before generating app.env so manual or automated compose restarts keep running the reviewed image. Constraint: Mini-server compose uses .env for restart-time variable resolution Rejected: Rely only on GitHub Actions job env | restarts outside the job lose that value Confidence: high Scope-risk: narrow Tested: git diff --check Not-tested: GitHub Actions deploy rerun pending PR merge
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary\n- persist the GitHub SHA backend image into the mini-server .env during deploy\n- keep compose-only FAIRPLAY_BACKEND_IMAGE out of app.env while preserving runtime env values\n- prevent later compose restarts from falling back to mutable latest\n\n## Verification\n- git diff --check\n- production recovery verified manually with fairplay-backend running songchih/fairplay-backend:4cf39dc6ac43e08b42f381716b6a69a88bc3b457 and external health 200/UP\n\n## Notes\n- CodeRabbit rate-limit or stale notices are non-blocking per project rule; concrete high-severity review findings should still be addressed.