fix(meta): mvt-oq-02-oq-04 strings in meta.additionalFiles#21876
Merged
Conversation
Convert the rich `{path, purpose}` entry to a plain string so the
auditor follows the parent companion file (MeanValueTheoremOQ02.lean,
which carries the inherited `taylor_lagrange_remainder` axiom that the
claimed `axiomCount: 1` already accounts for).
`scripts/auditor/find-targets.ts:169` skips non-string additionalFiles.
Same swap as PR #21874 (child slug mvt-oq-02-oq-04-oq-01) and PR #21863
(picks-theorem-oq-03 cross-polytope).
The `purpose` field's narrative is already covered by the slug's
`assumptions`, `originalContributions`, and `description` fields — no
information is lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Convert
meta.additionalFilesrich{path, purpose}entry to a plain string so the auditor follows the companion file.Evidence
Before:
After:
Why
scripts/auditor/find-targets.ts:169skips non-string entries:Rich-object meta entries silently disable chain-aggregate axiom/sorry counting. The slug claims
axiomCount: 1(inherited from the parent'staylor_lagrange_remainder); with the swap the auditor will correctly aggregate0 (main) + 1 (parent) = 1matching the claim.Same pattern as PR #21874 (child slug
mean-value-theorem-oq-02-oq-04-oq-01) and PR #21863 (picks-theorem-oq-03).The
purposenarrative is already preserved in this slug'sassumptions,originalContributions, anddescriptionfields.Validation
jq -e .passesnpx tsx scripts/auditor/find-targets.ts --issues --jsonreturns[](no new flags)meta.additionalFilesstrings vsleanFile.additionalFiles) unchanged for this slug (leanFileisnullhere; PR Enrich mean-value-theorem-oq-02-oq-04: populate leanFile + relatedProblems #21858 is adding the leanFile object separately).Concurrent PRs touching this slug
This PR touches lines 43–50 only (the
additionalFilesarray). No line overlap.Automated fix by lean-mechanic agent.