fix(mechanic): wire annotations into birthday-problem-oq-03-oq-01 index.ts#18843
Merged
Merged
Conversation
…ex.ts
Replace 4-line stub (`import meta; export { meta, annotations };`) with the
canonical full-template shape so the Lean source panel and typed exports work.
The 4-line stub falls through to the legacy `module.meta` fallback at
src/data/proofs/index.ts:60-79, which builds a ProofData but leaves
proof.source = ''. ProofViewer.tsx:20 then renders an empty Lean source panel
even though proofs/Proofs/BirthdayProblemOQ03OQ01.lean exists (9533 bytes).
After: default export hits src/data/proofs/index.ts:57; getProofSource()
lazy-imports the Lean source so ProofViewer can render the 9.5KB proof file
with its 6 annotations bound through typed exports.
This was referenced May 13, 2026
rjwalters
added a commit
that referenced
this pull request
May 13, 2026
The 4-line stub `export { meta, annotations }` left the gallery page
broken: `getProofAsync` consumed `module.default` (the truthy raw meta
dict) and never reached the fallback branch, so the page rendered with
proof/annotations/versionInfo undefined despite a 10.8KB annotations.json
on disk.
Replaced with the canonical 44-line template (matches PR #18749
triangle-angle-sum-oq-01 and PR #17885 lagrange-theorem-oq-02-oq-02):
imports annotationsJson, hardcodes `proofs/Proofs/Erdos1021OQ01.lean?raw`,
exports camelCase `erdos1021Oq01Proof`/`erdos1021Oq01Annotations`/
`erdos1021Oq01Data` plus `getProofSource()` for the async Lean fetch.
Restores: 5 keyInsights, 4 sections (header-imports, oq01-question,
trivial-vs-little-o, k3-settled, lower-bound), historicalContext,
problemStatement, proofStrategy, conclusion, 2 references
(Kővári-Sós-Turán 1954, Bondy-Simonovits 1974), 1 cross-reference
to parent erdos-1021, and the full 10.8KB annotation set.
Orthogonal to the in-flight wave (#18805 #18806 #18810 #18813 #18815
#18817 #18820 #18822 #18823 #18824 #18827 #18830 #18834 #18836 #18838
#18839 #18840 #18843 #18844 #18846 #18849 #18850 #18852 #18853) — each
PR fixes one slug; ~7 stubs remain after this one (gcd-algorithm-oq-02,
gcd-algorithm-oq-04, harmonic-divergence-oq-04, ramseys-theorem-oq-04,
erdos-114-oq-04, lagrange-theorem-oq-02-oq-02-oq-01,
angle-trisection-oq-05-oq-04, triangular-reciprocals-oq-01).
Co-authored-by: Robb Walters <r.j.walters@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Replace
birthday-problem-oq-03-oq-01/index.ts4-line stub (import meta; import annotations; export { meta, annotations };) with the canonical full-template shape so the Lean source panel and typed exports work.Evidence
Before (4 lines, 113 bytes):
defaultexport and nogetProofSource.src/data/proofs/index.ts:60-79, which builds aProofDatafrommodule.meta+module.annotationsbut leavesproof.source = ''.ProofViewer.tsx:20readsproof.source.split('\n')— Lean source panel renders empty for this slug despiteproofs/Proofs/BirthdayProblemOQ03OQ01.leancontaining 9,533 bytes.After (44 lines, canonical template):
birthdayProblemOq03Oq01Proof,birthdayProblemOq03Oq01Annotations,birthdayProblemOq03Oq01Data.defaultexport:birthdayProblemOq03Oq01Data(hits themodule.defaultpath atsrc/data/proofs/index.ts:57).getProofSource()lazy-importsproofs/Proofs/BirthdayProblemOQ03OQ01.lean?raw(9,533 bytes), populatingproof.sourcesoProofViewerrenders the Lean source panel with its 6 annotations.pnpm exec tsc --noEmit -p tsconfig.jsonexits 0.Scope
src/data/proofs/birthday-problem-oq-03-oq-01/index.ts.meta.json,annotations.json, or the Lean source.Companion to in-flight named-export-variant PRs #18822, #18830, #18834, #18836, #18838 (same 4-line stub class). Per local survey ~13 such slugs remain unclaimed (
chinese-remainder-constructive-oq-03,elementary-quadratic-reciprocity-oq-03-oq-01-oq-02,erdos-1021-oq-01,erdos-1036-oq-01,erdos-114-oq-04,erdos-1153,gcd-algorithm-oq-02,gcd-algorithm-oq-04,harmonic-divergence-oq-04,lagrange-theorem-oq-02-oq-01,lagrange-theorem-oq-02-oq-02-oq-01,lagrange-theorem-oq-05,partition-theorem-oq-03).Automated fix by lean-mechanic agent.