Merged
Conversation
Merged
Collaborator
Author
193ae91 to
c26b4c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Added
duplex: 'half'to the fetch request options and explicitly cast toRequestInittype in the dev server middleware.What changed?
Modified the fetch request configuration in
createMiddlewarefunction by:duplex: 'half'option to the request configurationRequestInitto ensure TypeScript compatibilityHow to test?
Why make this change?
This change addresses a potential issue with the Fetch API when handling certain types of requests. The
duplex: 'half'option specifies that the request is a "half-duplex" connection, which is necessary for some request types to work correctly with newer Fetch API implementations. The explicit type cast ensures TypeScript doesn't raise errors about the additional property.