refactor(rivetkit): move devtools to local script#4669
Conversation
|
🚅 Deployed to the rivet-pr-4669 environment in rivet-frontend
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Preview packages published to npmInstall with: npm install rivetkit@pr-4669All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-7c31bd8
docker pull rivetdev/engine:full-7c31bd8Individual packagesnpm install rivetkit@pr-4669
npm install @rivetkit/react@pr-4669
npm install @rivetkit/rivetkit-native@pr-4669
npm install @rivetkit/sqlite-wasm@pr-4669
npm install @rivetkit/workflow-engine@pr-4669 |
Code Review: refactor(rivetkit): move devtools to local scriptOverviewThis PR moves devtools from being loaded from the external CDN (releases.rivet.dev) to being self-hosted and served directly from the rivetkit manager. It also splits the engine guard onto an internal port (6423) so the manager can own port 6420 and serve devtools/inspector from a single origin. Solid architectural improvement. Issues1. Devtools endpoint not gated (runtime-router/router.ts:472) The new 2. Removed biome-ignore suppression (devtools-loader/index.ts:6) The 3. notGlobal: false without explanation (drivers/engine/actor-driver.ts:186) Explicitly setting a field to its presumed default is unusual. A short comment explaining why this needs to be set explicitly would help reviewers. Suggestions4. Path resolution fragility (devtools-loader/serve-devtools.ts) The path 5. Trailing blank line in publish.yaml (~line 467) After removing the R2 upload step, a blank line remains. Minor cleanup. Positive Changes
|

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: