Skip to content

fix(pegboard): repair follow-up build errors#4628

Closed
NathanFlurry wants to merge 1 commit into04-12-docs_pegboard-runner_explain_alloc_idx_eviction_invariantfrom
04-12-fix_pegboard_repair_follow-up_build_errors
Closed

fix(pegboard): repair follow-up build errors#4628
NathanFlurry wants to merge 1 commit into04-12-docs_pegboard-runner_explain_alloc_idx_eviction_invariantfrom
04-12-fix_pegboard_repair_follow-up_build_errors

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@claude
Copy link
Copy Markdown

claude bot commented Apr 13, 2026

PR Review: fix(pegboard): repair follow-up build errors

This is a small, targeted build-fix PR with two files changed. Changes look correct overall.

list_runner_config_enabled_dcs.rs

The stream chain now wraps its result in Ok(...) to satisfy the Result<Vec<u16>> return type. This is the correct fix — the async stream chain resolves to Vec<_>, not Result<Vec<_>>, so the outer Ok() wrapper is required.

Minor style note: the trailing comma after .await, inside Ok(...) is unconventional but valid Rust.

runner_pool_backfill.rs

Pattern fix: (_, (_, _, leaf))(_, _, leaf) — the previous nested tuple destructuring was incorrect for unpacking (Id, String, usize). The flat pattern is correct.

Constant reference fix: keys::runner_config::PROTOCOL_VERSIONuniversaldb::utils::keys::PROTOCOL_VERSION — this aligns with the canonical constant location. Worth double-checking that both constants were previously identical in value. If keys::runner_config::PROTOCOL_VERSION was a re-export or separate definition with the same value, behavior is unchanged; if they had different values, this is a semantic change worth noting.

Summary

Both fixes are minimal and correct. No test coverage concerns for pure build fixes. The draft status is appropriate while the parent branch stabilizes.

Nit: The PR description is empty — a one-liner explaining which upstream change introduced these errors would be helpful for future git archaeology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant