You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a documentation-only PR that adds a 9-line Rust doc comment (///) to fanout_to_replicas in engine/packages/epoxy/src/http_client.rs. No logic is changed. The comment documents the intentional best-effort, fault-tolerant semantics of the fanout function.
Accuracy
The doc comment correctly describes three key behavioral properties:
The function is best-effort: per-replica failures, timeouts, and errors are absorbed internally.
The return value reflects only successful responses; failures are logged and silently dropped.
Quorum enforcement is the caller's responsibility, not this function's.
This matches the implementation: the function catches both request errors and tokio::time::timeout timeouts, logs them with tracing::warn!, and continues collecting from remaining replicas.
Minor Suggestion
The comment states callers "get whatever successful responses arrived before the fanout quorum target was met or the pending requests were exhausted." This is accurate, but it might also be useful to note that all replica connections are initiated concurrently upfront via FuturesUnordered (not lazily), since that shapes the latency/connection-count tradeoff callers should understand. Not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: