Conversation
|
🚅 Deployed to the rivet-pr-4325 environment in rivet-frontend
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: feat: dev toolbarSummaryThis PR adds a developer debugging toolbar for the cloud frontend. The toolbar is gated behind both an APP_TYPE check and a specific localStorage flag. It exposes PostHog session recording controls, Sentry issue reporting, React Query cache clearing, and keyboard shortcuts for all of these. BugsDouble toolbar render in __root.tsxDevToolbar is added in two places: inside RootRoute (root-level) and inside CloudRoute (cloud-specific). For cloud apps both are in the same render tree, so two toolbars appear stacked at the bottom. DevToolbar should live in exactly one place. CloudRoute is the more appropriate home since Clerk context (useAuth, useUser, useOrganization) is only available there. The instance in RootRoute should be removed. localStorage type comparisonls.get("I_SOLELY_SWORE..._") !== true compares against true (boolean). If a developer enables it via localStorage.setItem(..., 'true') in the browser console, the check fails because ls.get() returns the string "true". Worth confirming the expected activation mechanism and adding a comment with exact enable instructions. Convention Violations (CLAUDE.md)Fragment-style commentsThe inline hotkey-section comments are fragments rather than complete sentences. Per project conventions these should be complete sentences, e.g. "Start a PostHog session recording." Minor Issues
Incidental changes worth confirming
Positive Notes
|
e251d7d to
c1da2dd
Compare
c1da2dd to
cb7b57e
Compare
Preview packages published to npmInstall with: npm install rivetkit@pr-4325All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-9b3d81d
docker pull rivetdev/engine:full-9b3d81dIndividual packagesnpm install rivetkit@pr-4325
npm install @rivetkit/react@pr-4325
npm install @rivetkit/rivetkit-native@pr-4325
npm install @rivetkit/sqlite-wasm@pr-4325
npm install @rivetkit/workflow-engine@pr-4325 |
cb7b57e to
8bb67fd
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: