Skip to content

fix(website): invalid import#3964

Closed
jog1t wants to merge 1 commit intomainfrom
01-17-fix_website_invalid_import
Closed

fix(website): invalid import#3964
jog1t wants to merge 1 commit intomainfrom
01-17-fix_website_invalid_import

Conversation

@jog1t
Copy link
Copy Markdown
Contributor

@jog1t jog1t commented Jan 17, 2026

No description provided.

@jog1t jog1t marked this pull request as ready for review January 17, 2026 03:53
@railway-app
Copy link
Copy Markdown

railway-app bot commented Jan 17, 2026

🚅 Deployed to the rivet-pr-3964 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 🕒 Building (View Logs) Web Jan 17, 2026 at 3:54 am
website 🕒 Building (View Logs) Web Jan 17, 2026 at 3:53 am
frontend-inspector 🕒 Building (View Logs) Web Jan 17, 2026 at 3:53 am

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-3964 January 17, 2026 03:53 Destroyed
Copy link
Copy Markdown
Contributor Author

jog1t commented Jan 17, 2026


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Jan 17, 2026

Merge activity

  • Jan 17, 3:53 AM UTC: jog1t added this pull request to the Graphite merge queue.
  • Jan 17, 3:54 AM UTC: CI is running for this pull request on a draft pull request (#3966) due to your merge queue CI optimization settings.
  • Jan 17, 3:54 AM UTC: Merged by the Graphite merge queue via draft PR: #3966.

graphite-app bot pushed a commit that referenced this pull request Jan 17, 2026
@claude
Copy link
Copy Markdown

claude bot commented Jan 17, 2026

Review of PR #3964: fix(website): invalid import

Summary

This PR fixes an invalid import path in the Hosting component by updating it to use the @rivetkit/example-registry package instead of the non-existent @/data/deploy/shared path. The change is correct and aligns with the codebase's move to centralize deployment options in the example-registry package.

✅ Positive Findings

  1. Correct import path: The new import from @rivetkit/example-registry is valid and properly configured in the website's package.json (line 31)
  2. Maintains functionality: The deployOptions export exists in the target package at frontend/packages/example-registry/src/index.ts:4
  3. Follows centralization pattern: Other files in the codebase are already using this import pattern (sitemap/mod.ts, data/templates/shared.ts)

⚠️ Critical Issue: Incomplete Fix

The same broken import exists in another file that was not updated:

  • File: website/src/content/docs/connect/index.mdx:1
  • Current state: Still using import { deployOptions } from "@/data/deploy/shared";
  • Impact: This file will fail to build/import correctly

Recommendation: Update website/src/content/docs/connect/index.mdx to use the same import:

-import { deployOptions } from "@/data/deploy/shared";
+import { deployOptions } from "@rivetkit/example-registry";

Additionally, there's a potential bug in connect/index.mdx line 11 where it references option.title, but the DeployOption interface uses displayName not title. This should be verified.

Code Quality

  • ✅ Clean, minimal change
  • ✅ Follows existing patterns in the codebase
  • ✅ No security concerns
  • ✅ No performance implications

Test Coverage

  • ⚠️ Consider adding a build test to verify all imports resolve correctly
  • The website build should be tested to ensure both files work after the fix

Recommendation

Request changes - Please update the additional file mentioned above to complete the fix.

@graphite-app graphite-app bot closed this Jan 17, 2026
@graphite-app graphite-app bot deleted the 01-17-fix_website_invalid_import branch January 17, 2026 03:54
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Jan 17, 2026

Graphite Automations

"Test" took an action on this PR • (01/17/26)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant