[Graphite MQ] Draft PR GROUP:spec_943039 (PRs 3961)#3962
Closed
graphite-app[bot] wants to merge 1 commit intomainfrom
Closed
[Graphite MQ] Draft PR GROUP:spec_943039 (PRs 3961)#3962graphite-app[bot] wants to merge 1 commit intomainfrom
graphite-app[bot] wants to merge 1 commit intomainfrom
Conversation
### TL;DR Added actor count query functionality and improved the onboarding experience with better error handling and deployment URL formatting. ### What changed? - Added a new `actorsCountQueryOptions` function to efficiently query the count of actors - Updated the frontend setup to use the new actor count query instead of fetching all actors - Improved actor error display to show crash messages - Fixed deployment URL formatting by properly extracting the base URL - Added Posthog tracking for when users skip onboarding - Enhanced the namespace route to use the new actor count query for determining if actors exist - Improved error handling in the actor status label component to display more specific crash messages ### How to test? 1. Navigate to the getting started flow and verify the actor count is displayed correctly 2. Check that deployment URLs are properly formatted in the frontend setup 3. Trigger an actor crash and verify the error message is displayed correctly 4. Skip onboarding and confirm the Posthog event is captured ### Why make this change? The previous implementation was inefficient as it fetched all actors just to get a count. This change optimizes performance by providing a dedicated endpoint for actor counts. Additionally, the improved error handling and URL formatting enhance the user experience during onboarding by providing clearer feedback and properly formatted links.
|
This PR was not deployed automatically as @graphite-app[bot] does not have access to the Railway project. In order to get automatic PR deploys, please add @graphite-app[bot] to your workspace on Railway. |
graphite-app
bot
deleted the
gtmq_spec_943039_1768621230193-81b2aa37-ea4c-4fd0-821f-42e24c06b446
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.
The following PRs are included in this draft PR: