Skip to content

fix: dont clear ingress ports on reschedule #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MasterPtato wants to merge 1 commit into from
Closed

fix: dont clear ingress ports on reschedule #2700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions packages/edge/services/pegboard/src/workflows/actor/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,20 +1393,12 @@ async fn clear_ports_and_resources(

let (
build_res,
ingress_ports,
(selected_resources_cpu_millicores, selected_resources_memory_mib),
_,
) = tokio::try_join!(
ctx.op(build::ops::get::Input {
build_ids: vec![input.image_id],
}),
sql_fetch_all!(
[ctx, (i64, i64), pool]
"
SELECT protocol, ingress_port_number
FROM ports_ingress
",
),
sql_fetch_one!(
[ctx, (Option<i64>, Option<i64>), pool]
"
Expand All @@ -1428,13 +1420,13 @@ async fn clear_ports_and_resources(
.fdb()
.await?
.run(|tx, _mc| {
let ingress_ports = ingress_ports.clone();
async move {
destroy::clear_ports_and_resources(
input.actor_id,
input.image_id,
Some(build.allocation_type),
ingress_ports,
// NOTE: Ingress ports are not cleared upon reschedule, they are reused
Vec::new(),
Some(input.runner_id),
Some(input.client_id),
Some(input.client_workflow_id),
Expand Down
Loading