Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(risedev): CONNECTOR_LIBS_PATH for frontend is not set #20027

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 6, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

refactor to bring common env vars together.

Found while testing iceberg engine
https://github.com/risingwavelabs/risingwave/blob/xxchan/unpleasant-catshark/src/frontend/src/handler/create_table.rs#L1743

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan xxchan requested a review from BugenZhao January 6, 2025 05:27
@github-actions github-actions bot added the type/fix Bug fix label Jan 6, 2025
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor to bring common env vars together.

Cool

@xxchan xxchan enabled auto-merge January 6, 2025 06:09
@xxchan xxchan added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@xxchan xxchan added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 6, 2025
@xxchan xxchan enabled auto-merge January 6, 2025 07:44
@xxchan xxchan disabled auto-merge January 6, 2025 08:13
@xxchan xxchan added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit b05f864 Jan 6, 2025
29 of 30 checks passed
@xxchan xxchan deleted the xxchan/unpleasant-catshark branch January 6, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants