Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): introduce alert overview for dev dashboard #20014

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Jan 3, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The oncaller and engineers are usually more concerned with the dev dashboard. So the PR introduces Alert and Error to the dev dashboard, and adds more alert metrics and guidance.
It is hoped that the Alert and corresponding guidance will help the oncaller to locate the corresponding metrics and find the problems faster. However, it is important to note that alerts under this panel may occur at the same time, so we need to minimize duplicate metrics and carefully identify the root cause when they occur.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@Li0k Li0k changed the title feat(dashboard): introduce alert overview for dev dashboard @Li0k feat(dashboard): introduce alert overview for dev dashboard Jan 3, 2025
@Li0k Li0k requested review from hzxa21 and zwang28 January 3, 2025 08:02
@Li0k Li0k marked this pull request as ready for review January 3, 2025 08:02
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Li0k Li0k enabled auto-merge January 7, 2025 07:56
@Li0k Li0k added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit efbeec1 Jan 7, 2025
35 of 36 checks passed
@Li0k Li0k deleted the li0k/dashboard_alert branch January 7, 2025 09:15
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants